[vlc-devel] Re: vlc: svn commit r13710 (jpsaman)

[Jean-Paul Saman]

Christophe Mutricy wrote:
>>Question: What is the current policy for a failed detection of 
>>headerfiles, while the --enable-xx is used on the configure-line?
>>
>>I think the configure step should fail, because a user requested a 
>>feature that his build environment is not correctly setup for. The 
>>alternative is that he finds out during or after the build, which IMHO 
>>is wrong and very annoying.
> 
> 
> I agree.
> 
> 
>>The above commit breaks the build on buildbots, which don't have the 
>>necessary development headers/libraries for libraw1394, libavc1394 and 
>>librom1394.
> 
> 
> 
> We don't specify --enable-dv in the configure of the buildbots so it
> should just gives a warning and not stop. So i believe you need to add a
> test to see if --enable-dv was set to yes before giving the error.
> 
> 
Oh yes it is for i386-Sid and AMD64-Sid. So if someone with access to 
those buildbots can change the environment or remove --enable-dv from 
the commandline.

The following configure line is from i386-Sid buildbot.

/bin/sh -c CC=`pwd`/debian/gcc-snapshot; ./configure --enable-debug 
--prefix=/usr --enable-ggi --enable-sdl --enable-esd --enable-mad 
--enable-alsa --enable-lirc --enable-a52 --enable-aa --enable-dvbpsi 
--enable-xosd --enable-mozilla --enable-mp4 --enable-dvb
--enable-dv <<<< HERE IT IS >>>>
--enable-ogg --enable-vorbis --enable-wxwidgets --enable-flac 
--enable-skins2 --enable-freetype --disable-mkv --enable-v4l 
--enable-pvr --enable-caca --enable-livedotcom --enable-libmpeg2 
--enable-dtc --enable-fribidi --enable-mod --enable-theora 
--enable-modplug --enable-dvdnav --enable-gnutls --enable-ffmpeg 
--enable-nucurses
  in dir /home/buildslave/slave/sid-trunk-i386/build (timeout 1200 secs)
  argv: ['/bin/sh', '-c', 'CC=`pwd`/debian/gcc-snapshot; ./configure 
--enable-debug --prefix=/usr --enable-ggi --enable-sdl --enable-esd 
--enable-mad --enable-alsa --enable-lirc --enable-a52 --enable-aa 
--enable-dvbpsi --enable-xosd --enable-mozilla --enable-mp4 --enable-dvb 
--enable-dv --enable-ogg --enable-vorbis --enable-wxwidgets 
--enable-flac --enable-skins2 --enable-freetype --disable-mkv 
--enable-v4l --enable-pvr --enable-caca --enable-livedotcom 
--enable-libmpeg2 --enable-dtc --enable-fribidi --enable-mod 
--enable-theora --enable-modplug --enable-dvdnav --enable-gnutls 
--enable-ffmpeg --enable-nucurses']
  environment: {'_': '/usr/bin/make', 'TERM': 'screen', 'SHELL': 
'/bin/sh', 'HISTFILE': '/home/buildslave/.history', 'SHLVL': '1', 
'OLDPWD': '/home/buildslave', 'HISTORY': '100', 'VISUAL': 'vim', 
'SAVEHIST': '100', 'MAKELEVEL': '1', 'PWD': '/home/buildslave/slave', 
'LOGNAME': 'buildslave', 'EDITOR': 'vim', 'LESSCHARSET': 'latin1', 
'PATH': 
'/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/local/bin:/sbin:/usr/sbin:/usr/games', 
'HOME': '/home/buildslave', 'PS1': '%{\x1b[39;36;1m%}%T%{\x1b[0m%} 
%{\x1b[39;31;1m%}%n%{\x1b[0m\x1b[39;33;1m%}@%{\x1b[39;37;1m%}%m sid-i386 
%{\x1b[39;32;1m%}%~%{\x1b[0m\x1b[39;33;1m%}%#%{\x1b[0m%} ', 'MFLAGS': 
'', 'MAKEFLAGS': '', 'USER': 'buildslave'}

Grtz,
Jean-Paul Saman.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html