[vlc-devel] Re: vlc: svn commit r13724 (oaubert)

[Filippo Carone]

On Wed, Dec 14, 2005 at 11:14:20AM +0100, Subversion daemon wrote:
> r13724 | oaubert | 2005-12-14 11:14:20 +0100 (Wed, 14 Dec 2005) | 2 lines
> Changed paths:
>    M /trunk/src/control/core.c
> 
> src/control/core.c: correctly set start-time through playlist_ItemAddOption
> 

 This implementation still doesn't set the start-time, since

	if( p_playlist->status.p_item )
        {
            char psz_from[20];
            snprintf( psz_from, 20, "start-time=%i", i_from);
            playlist_ItemAddOption( p_playlist->status.p_item, psz_from);
        }

 and if the playlist is not already playing the p_item is null. A
working, but still design-broken, implementation is:

    if( p_playlist->i_size )
    {
        int i_from; 
	char * psz_from = (char *) malloc (20 * sizeof(char));
	playlist_item_t * p_item = *(p_playlist->pp_items);

        i_from = mediacontrol_position2microsecond( p_playlist->p_input, a_position ) / 1000000;
	
        /* Set start time */
	snprintf( psz_from, 20, "start-time=%i", i_from);
	playlist_ItemAddOption( p_item, psz_from);

        vlc_mutex_unlock( &p_playlist->object_lock );

        playlist_Play( p_playlist );
    }

where you access the first p_item directly from pp_items.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html