[vlc-devel] Re: vlc: svn commit r10012 (fenrir)

[Ross Finlayson]

At 01:10 AM 2/21/05, you wrote:
>r10012 | fenrir | 2005-02-21 10:10:53 +0100 (Mon, 21 Feb 2005) | 6 lines
>Changed paths:
>    M /trunk/modules/demux/livedotcom.cpp
>
>  * livedotcom: automatic TCP rollover when no data was received in 900ms and
>  auto eof when no more data received in 3s (not tested a lot, so please 
> report
>  any problem).

Thanks for doing this.  This will be a big help for those people stuck 
behind stupid firewalls.

One comment, though: As you note in your comments, your new "RollOverTCP()" 
function duplicates a *lot* of code from "Open()".  It would be better to 
remove this duplication, by having just a single 'RTSP open' routine that 
requests either UDP or TCP streaming, based on a parameter.

(As far as the LIVE.COM library is concerned, the choice of UDP or TCP 
shows up in only one place - the call to "RTSPClient::setupMediaSubsession()".)


	Ross Finlayson
	LIVE.COM
	<http://www.live.com/>

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html