[vlc-devel] Re: vlc: svn commit r11754 (rocky)

[R. Bernstein]

Cyril Deguet writes:
 > hi,
 > when libcdio is enabled, configure fails if you don't have libvcdinfo,

The solution is obvious - install libvcdinfo! (Just kidding.) 

Sorry, should be fixed now. See the commit entry for revision 11769
for details.

 > which prevents from just enabling cddax, which I guess has nothing to do
 > with libvcdinfo...

Your right that cddax has nothing to do with libvcdinfo, and that
configure failed if you didn't have libvcdinfo. But as I fathom
things, it also failed if you didn't have libcdio installed or a new
enough version of it. (If on the earlier bug report by Rémi
Denis-Courmont a log of the configure output were given, I might have
caught this earlier.)

To make things more precise, if libcdio is enabled, which *is* needed
for cddax, we also make a test for libvcdinfo. (It doesn't make sense
to test for libvcdinfo independently of libcdio sense libvcdinfo needs
libcdio). The problem was that if any of these failed, configure
halted rather than gave a warning and continued.

I would like to improve the doc comment for the PKG_CHECK_MODULES()
macro to note it's behavior better, but it looks like that comes from
outside vlc.

 > What is more, if I understand well, libcdio is used only by cddax and vcdx
 > plugins, which are disabled by default, so it doesn't make sense to make
 > libcdio enabled by default.

libcdio is now also used in media probing in wxwindows. If libcdio
were disabled by default either one would have to enable it when one
enables cddax and vcdx or there'd have to be even more complex logic
on those to by default enable it.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html