[vlc-devel] Re: [PATCH] Use Matroska and Ebml in PIC flavor

[Steve Lhomme]

That will only work if 0.7.7 of libmatroska is made mandatory in the 
preivous checks. What is the version currently mandatory (minimum) ? I 
remember upgrading the libebml one, but not the libmatroska one. BTW, 
does that mean that matroska could be build at a separate plugin ?

Diego 'Flameeyes' Pettenò wrote:
> Since version 0.7.7 of libmatroska (and equivalent version of libebml) the 
> default packages from upstream build both .a and .so libraries, so there's 
> always a PIC library to build against. The attached patch uses PIC-enabled 
> libebml and libmatroska instead of looking for libebml_pic and 
> libmatroska_pic.
> 
> I'm using this since 0.8.2 in Gentoo and works fine; I know it's late for 
> 0.8.4, but maybe for next version it could be of help.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> libmatroska and libebml did not ship with PIC-enabled archives or shared
> objects, and some distributions shipped them with lib(ebml|matroska)_pic name.
> Portage versions are since a long time built in both .a and .so flavors, with
> the same name. Now also upstream does this way so we're safe.
> 
> Index: vlc-0.8.4-test3/configure.ac
> ===================================================================
> --- vlc-0.8.4-test3.orig/configure.ac
> +++ vlc-0.8.4-test3/configure.ac
> @@ -2017,16 +2017,9 @@ if test "${enable_mkv}" != "no" -a "${CX
>                if test "${SYS}" = "darwin"; then
>                  VLC_ADD_CXXFLAGS([mkv],[-O1])
>                fi
> -              AC_CHECK_LIB(ebml_pic, main, [
> -                # We have ebml_pic, that's good, we can build an mkv.so plugin !
> +              AC_CHECK_LIB(ebml, main, [
>                  VLC_ADD_PLUGINS([mkv])
> -                VLC_ADD_LDFLAGS([mkv],[-lmatroska_pic -lebml_pic])
> -              ], [
> -                AC_CHECK_LIB(ebml, main, [
> -                  # We only have libebml, make mkv.a a builtin
> -                  VLC_ADD_BUILTINS([mkv])
> -                  VLC_ADD_LDFLAGS([mkv],[-lmatroska -lebml])
> -                ])
> +                VLC_ADD_LDFLAGS([mkv],[-lmatroska -lebml])
>                ])
>              ],
>              [AC_MSG_RESULT([no])

-- 
robUx4 on blog <http://robux4.blogspot.com/>

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html