[vlc-devel] Re: wx compatiblity

[· zcot ·]

I can provide additional info on this.

Firstly, I think that backward compatibility is not thrown out the window.

Next, if this patch is viable, then it's incomplete due to this(patch 
uncommitted gibalou is having vacation):
http://www.via.ecp.fr/via/ml/vlc-devel/2005-10/msg00198.html
which relates to ticket 360:
http://trac.videolan.org/vlc/ticket/360
and discussions on irc, where 3 or 4 additions of SetMinSize are made in 
order to enforce a minimum size of the main window at all times.

the multiple calls like:
>-    SetMinSize( s );

are the implied version of this:
>-    this->SetMinSize( s );

where `this' is the Interface object.

The class Interface object inherits wxFrame.
wxFrame inherits wxWindow.
and wxWindow::SetMinSize is the call.

The intention is to set the outermost portion of the interface:
Interface::wxFrame::wxWindow::SetMinSize()
..and not worry much of the smaller and numerous inner frames and/or sizers 
within.. -just let them auto-size and act on their own due to their content 
and let them act the way that they should, and then come in after that and 
say that the collection of them make up the outermost minimum window size.

The wx2.4.2 documentation shows this same inhereritance design as the code 
so I couldn't imagine where that one line would be a problem in the wx 
library.

If this issue needs to be addressed then let it be address with the 
consideration of a full implementation for the minimum size at all times(as 
in the above uncommitted patch).

love,
zcot :)

ps. what is the compilation problem?



>From: Daniel Stränger <vlc at schmaller.de>
>Reply-To: vlc-devel at videolan.org
>To: vlc-devel at videolan.org
>Subject: [vlc-devel] wx compatiblity
>Date: Thu, 13 Oct 2005 11:48:16 +0200
>
>hi!
>i know you're planning vlc to require version 2.6 of wxWidgets, right?
>but this very small patch would enable compiling with wx2.5.1 and
>imho also works with 2.6.
>could somebody check it, please!?
>
>best regards,
>daniel


>Index: modules/gui/wxwidgets/interface.cpp
>===================================================================
>--- modules/gui/wxwidgets/interface.cpp	(Revision 12824)
>+++ modules/gui/wxwidgets/interface.cpp	(Arbeitskopie)
>@@ -339,7 +339,7 @@
>          s2 = video_window->GetSize();
>          s.SetHeight( s.GetHeight() - s2.GetHeight() );
>      }
>-    SetMinSize( s );
>+    frame_sizer->SetMinSize( s );
>
>      /* Show extended GUI if requested */
>      if( ( b_extra = config_GetInt( p_intf, "wx-extended" ) ) )

_________________________________________________________________
Don’t just search. Find. Check out the new MSN Search! 
http://search.msn.click-url.com/go/onm00200636ave/direct/01/

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html