[vlc-devel] svn commits r12927 etc.

Marian Durkovic md at bts.sk
Sun Oct 23 13:14:50 CEST 2005


On Sun, Oct 23, 2005 at 12:00:58PM +0200, Subversion daemon wrote:
> r12927 | gbazin | 2005-10-23 12:00:58 +0200 (Sun, 23 Oct 2005) | 1 line
> Changed paths:
>    M /trunk/src/video_output/video_output.c
> * src/video_output/video_output.c: get rid of hack for for grey line with 
> hdtv streams (proper way is to have video outputs support cropping to 
> i_visible_width/height).

Unfortunately, only xvideo is able to do cropping at display time, all other
video outputs (x11, sdl, directx, opengl) don't support this.

My solution utilised the fact, that for video outputs giving only 1 direct
buffer, cropping was done during memcpy() before the picture was passed
to the video output. Now it's not done there and greyline bug is back :-(

I'm afraid doing yet another memcpy in all videooutputs is not an option, 
since CPU is scarce resource at HDTV rates anyway. 

Wouldn't it therefore make sense to postpone this work until the vout rework 
planned for 0.8.5 anyway?

	With kind regards,


This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html

More information about the vlc-devel mailing list