[vlc-devel] Re: [patch] skins2 msvc fixes

[Brian Robb]

>Applied, thanks.
>--
>Gildas

Thanks.

I made another patch later on when trying to compile skins2 here:
http://sphere.sf.net/flik/files/flik.skins2_msvc.patch

The main change is due to skins2/utils/var_tree.hpp

You have:
(I've removed the extra bits to make it easier to explain here)

class VarTree
{
    public:
        list<VarTree> m_list;
};

Which, will not compile in msvc because of the way list<T> is implemented in 
msvc...
So I added #ifdef _MSC_VER and #endif, and #ifndef _MSC_VER and #endif
around all the VarTree related code so that it would compile...

Although you may want to use:
  #if defined(_MSC_VER) && _MSC_VER <= 1200
  /* code */
  #endif

  for
  #ifdef _MSC_VER
  /* code */
  #endif

  And:

  #if defined(_MSC_VER) && _MSC_VER <= 1200
  #else
  /* code */
  #end

  for

  #ifndef _MSC_VER
  /* code */
  #endif


Maybe you could use add a HAVE_VAR_TREE define and use #ifdef HAVE_VAR_TREE 
instead?

After I add that, it then has no compile errors...

I get the following linking errors:
Linking...
  Creating library Debug/libskins2_plugin.lib and object 
Debug/libskins2_plugin.exp
LINK : warning LNK4098: defaultlib "LIBCD" conflicts with use of other libs; 
use /NODEFAULTLIB:library
freetype2110ST_D.lib(ftinit.obj) : error LNK2001: unresolved external symbol 
_otv_module_class
freetype2110ST_D.lib(ftinit.obj) : error LNK2001: unresolved external symbol 
_autofit_module_class
freetype2110ST_D.lib(ftglyph.obj) : error LNK2001: unresolved external 
symbol _FT_Bitmap_Copy
freetype2110ST_D.lib(ftglyph.obj) : error LNK2001: unresolved external 
symbol _FT_Bitmap_New
freetype2110ST_D.lib(ftglyph.obj) : error LNK2001: unresolved external 
symbol _FT_Bitmap_Done
plugins\libskins2_plugin.dll : fatal error LNK1120: 5 unresolved externals
Error executing link.exe.

libskins2_plugin.dll - 6 error(s), 1 warning(s)

But that's just because I don't know what libraries to link to, I think.


I figure VarTree is used for the playlist/playlist-tree so it's not entirely 
essential?
(I just want to fix problems that occur in skins2 and then someone else
can compile it with playlist/playlist-tree support again for the release.)

Anyway, thanks.


-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html