[vlc-devel] Re: [patch] skins2 msvc fixes

Cyril Deguet cyril.deguet at via.ecp.fr
Sat Sep 10 15:07:18 CEST 2005


On Fri, Sep 09, 2005, Brian Robb wrote:
> class VarTree
> {
>    public:
>        list<VarTree> m_list;
> };
> 
> Which, will not compile in msvc because of the way list<T> is implemented 
> in msvc...
> So I added #ifdef _MSC_VER and #endif, and #ifndef _MSC_VER and #endif
> around all the VarTree related code so that it would compile...

I'm sure dionoea can do the *real* fix for that ;) (hint: pointers...)
This code is supposed to be portable, a #ifdef is definitely not a
solution!
As for the #pragma warning, there is already one in skin_common.hpp so
it would be a better place to put it I think.

-- 
Cyril

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html



More information about the vlc-devel mailing list