[vlc-devel] Re: [PATCH] sout crop and padd

[Udo Richter]

Clément Stenac wrote:
> However, as we are currently under feature freeze for 0.8.4, this patch
> cannot be accepted right now in the trunk.

Although the patch is carefully designed not to change any existing 
behavior, I fully understand that such a major patch cant be accepted in 
a late development cycle.

I will continue to port (and publish) this patch to future releases 
anyway, since its highly useful for my VDR plugin at the far end of the 
stream. And for a final integration: Its never too early to start 
talking about it. ;)

> I haven't looked toroughly, but it doesn't seem possible to split out
> the "fix crop" part, right, as it is "integrated" ?

It would require at least the modified filter to do the cropping, and 
thats already one of the biggest impacts. In pre-0.8, this was directly 
handled by ffmpeg, but since 0.8 this is redirected to the filters, 
which simply cannot crop at all.

> Anyway, this patch fits in our ongoing effort for 0.8.5,
> reworking completely the video output : 
> http://wiki.videolan.org/index.php/VoutRework
> (even if the cropping/padding here should be done without ffmpeg)

Sounds nice. Since the redesign includes a successor of filter2 anyway, 
its probably a good idea to add crop/padd functionality directly into 
it. Maybe my filter implementation can even be of use as transitional 
early implementation of the next generation filter...

Cheers,

Udo

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html