[vlc-devel] Re: vlc: svn commit r12664 (jpsaman)

[Gildas Bazin]

On Sunday 25 September 2005 16:25, Jean-Paul Saman wrote:
> Gildas Bazin wrote:
> 
> >On Sunday 25 September 2005 10:52, Subversion daemon wrote:
> >  
> >
> >>r12664 | jpsaman | 2005-09-25 11:52:28 +0200 (Sun, 25 Sep 2005) | 1 line
> >>Changed paths:
> >>   M /trunk/modules/access/rtsp/real.c
> >>   M /trunk/modules/access/rtsp/real_rmff.c
> >>   M /trunk/modules/access/rtsp/real_rmff.h
> >>   M /trunk/modules/access/rtsp/real_sdpplin.c
> >>   M /trunk/modules/access/rtsp/rtsp.c
> >>
> >>Fix several memory leaks and do a bit of coding style cleanup.
> >>
> >>    
> >>
> >
> >Hmmm, I actually didn't want to change the coding style of the real_* 
files 
> >cause it will just make it impossible to diff/sync it against xine's 
> >version.
> >  
> >
> I understand Gildas, but reading through the code there were so many 
> memory leaks that I just decided to fix them. Perhaps it is better to 
> not sync with xine's version anymore because it is leaking memory all 
> over the place.
> 

Well it would have been nicer to fix the bugs without modifying the coding 
style and just feedback the fixes to xine. But well it's done so I guess 
there's no point in trying to go back.

--
Gildas

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html