[vlc-devel] vlc: svn commit r15379 (courmisch)

[Subversion daemon]

r15379 | courmisch | 2006-04-27 22:18:14 +0200 (Thu, 27 Apr 2006) | 15 lines
Changed paths:
   M /trunk/modules/access/file.c
   M /trunk/src/network/httpd.c
   M /trunk/src/network/io.c
   M /trunk/src/network/tcp.c

Whenever using select() companion macro FD_SET(), one must ensure that
the specified file descriptor does not exceeds the fd_set limit (FD_SETSIZE).
Registering a file descriptor above this limit is not defined (read: this is
a buffer overflow).

This is not normally exploitable on Linux because FD_SETSIZE equals the
default limit for file descriptors per processes, but should work on BSDs.
Cygwin is also very prone to this problem (but right, we don't use it). As
for Windows, it will overflow if you try to select() more than 64 sockets at
a time (regardless of the total numbers of socket), but for the sake of
simplicity and portability, this patch actually prevent opening more than
64 sockets at all.

There are still quite a bunch of plugins that needs fixing.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html