[vlc-devel] Re: vlc: svn commit r14218 (hartman)
jean-paul.saman at planet.nl
Sat Feb 11 11:59:28 CET 2006
Rémi Denis-Courmont wrote:
> Le Samedi 11 Février 2006 01:01, Subversion daemon a écrit :
>>* Don't put huge pictures on the stack. It is limited on some
>>platforms. use malloc. * Use the correct pitch values when reading
>>from and writing to pictures (out pitch can differ from in pitch, and
>>there is also visible pitch and visible lines.
> Using malloc instead of the stack, particularly in a multithreaded
> context, is more often than not very very poor, performance-wise.
> I don't know if that is critical here, but shouldn't it rather be on
> stack, *except* on loosy architecture ?
Never put large buffers on the stack you will run out of your stack
space very quickly. If perfomance is a concern then there are other ways
of getting a buffer, eg: use a bufferpool
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
More information about the vlc-devel