[vlc-devel] Some bugs (+ fixes)

[Hans-Peter Fischer]

I'd like to inform you of some bugs I've found in vlc 0.8.4a and the 
solutions that work for me. (Warning: I'm not a professional programmer ;-)

1.

Movie stops in the middle of last chapter. Example: Artificial Eye DVD 
"Ivan's Childhood".

Error messages:
- "dsi->dsi_gi.zero1 == 0" (from libdvdread) and "i_pack_len >= 1024" 
(from vlc's dvdread access module)
or:
- "Expected NAV packet but none found." (when using libdvdnav only)

My solution:
In modules/access/dvdread.c, line 1151, replace
"p_sys->i_next_vobu = p_sys->i_cur_block +
	( p_sys->dsi_pack.vobu_sri.next_vobu & 0x7fffffff );"
by
"p_sys->i_next_vobu = p_sys->i_cur_block + p_sys->i_pack_len + 1;"

2.

With some deinterlace filters (e. g. "blend", I think), vlc exits due to 
an "Illegal instruction".
Cause: in modules/video_filter/deinterlace.c, line 225, you check for 
"CPU_CAPABILITY_MMX". The AMD K6 processor has MMX capability, but does 
not support the "pavgb" instruction.

My fix for the K6:
Check for CPU_CAPABILITY_3DNOW and replace pavgb in line 949 by 
"pavgusb" (and "emms" in line 1004 by "femms"?).

3.

Sometimes, DVD subtitles are almost totally transparent. Example: 
"Platform" from Artificial Eye. (I already reported this bug a couple of 
years ago.)

My solution:
In modules/codec/spudec/parse.c, move lines 85 - 88 to line 244. (That's 
where the warning message "ignoring blank alpha palette" is.)

4.

A wishlist item/suggestion: amend line 1987 in 
modules/video_output/x11/xcommon.c so that XV_BRIGHTNESS can be set from 
outside (e. g. via getenv).

I hope the above will help you to further improve your excellent program.

Greetings,

Hans-Peter


-- 
::: http://www.stalkerzone.net/ :::

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html