[vlc-devel] [matthieu castet <castet.matthieu at free.fr>] strange ffmpeg direct rendering mode

[System administration]

The deleted attachment is at:
    <http://www.videolan.org/~admin/20060115-videolan/log1>
    <http://www.videolan.org/~admin/20060115-videolan/log2>
 

----- Forwarded message from matthieu castet <castet.matthieu at free.fr> -----

From: matthieu castet <castet.matthieu at free.fr>
Date: Sun, 15 Jan 2006 15:09:31 +0100
Subject: strange ffmpeg direct rendering mode
	autolearn=failed version=3.0.3

Hi,

I have put some trace in modules/codec/ffmpeg/video.c in order to see if 
we call ffmpeg_CopyPicture (the patch is attached as diff).

After that for the same file somtimes vlc use ffmpeg_CopyPicture 
(attached file log2) others times it doesn't use it (attached file log1).

If i understand well ffmpeg_CopyPicture does some copy stuff, so it 
should be avoided.

Why for the same file videolan doesn't always use direct rendering mode ?

Thanks

Matthieu

Index: video.c
===================================================================
--- video.c	(r??vision 13856)
+++ video.c	(copie de travail)
@@ -504,6 +504,7 @@
         p_sys->i_buffer = p_block->i_buffer;
         p_dec->p_vlc->pf_memcpy( p_sys->p_buffer, p_block->p_buffer,
                                  p_block->i_buffer );
+
         memset( p_sys->p_buffer + p_block->i_buffer, 0,
                 FF_INPUT_BUFFER_PADDING_SIZE );
 
@@ -587,6 +588,7 @@
         }
         else
         {
+		printf("direct\n");
             p_pic = (picture_t *)p_sys->p_ff_pic->opaque;
         }
 
@@ -785,6 +787,7 @@
                                 picture_t *p_pic, AVFrame *p_ff_pic )
 {
     decoder_sys_t *p_sys = p_dec->p_sys;
+    printf("copy....\n");
 
     if( ffmpeg_PixFmtToChroma( p_sys->p_context->pix_fmt ) )
     {




----- End forwarded message -----

-- 
System administration <admin at via.ecp.fr>
VIA, École Centrale Paris, France

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html