[vlc-devel] Re: bug in EStoPES (pes.c)

Alex Antropoff alant at transtelecom.md
Tue Jan 24 15:08:35 CET 2006


On Tue, Jan 17, 2006 at 02:42:17PM +0200, Alex Antropoff wrote:
AA> Hello, 
AA> modules/mux/mpeg/pes.c line 290  
AA> p_es = block_Realloc( p_es, i_pes_header, p_es->i_buffer );
AA> 
AA> If size of buffer is large, block_Realloc will create new block and 
AA> we loss p_data, after that vlc crashes at line 306.
AA> 
AA> Please, make fix like this:
AA> 
AA> --- modules/mux/mpeg/pes.c.orig 2006-01-17 11:17:05.000000000 +0200
AA> +++ modules/mux/mpeg/pes.c      2006-01-17 10:56:03.000000000 +0200
AA> @@ -288,6 +288,7 @@
AA>          if( p_es )
AA>          {
AA>              p_es = block_Realloc( p_es, i_pes_header, p_es->i_buffer );
AA> +            p_data = p_es->p_buffer+i_pes_header;
AA>              /* reuse p_es for first frame */
AA>              *pp_pes = p_pes = p_es;
AA>              /* don't touch i_dts, i_pts, i_length as are already set :) */
AA> 
So ? 

-- 
Regards, 
Alex Antropoff

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html



More information about the vlc-devel mailing list