[vlc-devel] Re: Ticket #487: patch

[Jean-Paul Saman]

hobophobe wrote:
> Filippo Carone wrote:
> 
>> Hi,
>> I recently changed the behaviour of the snapshot function to accept a 
>> filename submitted by the user. I think giving a complete name to vlc 
>> is better than adding several variables the user has to fill. 
>> Currently if in snapshot-path you give a path not including the 
>> filename, then vlc saves snapshot in the usual way, otherwise if the 
>> path is not a folder, than vlc assumes it is a filename as saves it 
>> so. I wouldn't apply this patch since I think the current behaviour is 
>> more intuitive to the programmer.
> 
> 
> My patch does not override yours, but if the pathname is a folder (or if 
> none is specified) it adds the prefix/suffix choices (if any are given, 
> if not it uses the number alone; 'vlcsnap' is the default prefix).
> 
> That said, whatever you guys decide is fine with me. I wrote the patch 
> due to the existence of that ticket and that I felt it was something 
> easy enough for someone with as little experience as I have to implement.
> 
> -hobophobe
> 
The VLC team welcomes your contribution at solving Ticket #487. However 
in the meantime another implementation that also solves it was submitted 
and the team favor that implementation over yours.

Anyway we thank you for contributing and hope this won't shy you off 
from future contributions.

Greetings,
Jean-Paul Saman.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html