[vlc-devel] Re: [PATCH] Issues with SDP parsing

[Derk-Jan Hartman]

On 6-mrt-2006, at 18:18, Christophe Mutricy wrote:

> On Mon, Mar 06, 06 at 17:05 +0100, Alexander Gall wrote:
>> I believe that the "m=" field is mandatory in SDP.  Currently,
> [...]
>>                  msg_Warn( p_obj, "invalid transport port %i",  
>> i_port );
>> +                FREE( psz_uri );
>> +                return VLC_EGENERIC;
> [...]
>>          }
>> +    } else {
>> +      msg_Warn( p_obj, "missing m field" );
>> +      FREE( psz_uri );
>> +      return VLC_EGENERIC;
>
> If we return a VLC_EGENERIC i think we could go for a msg_Err().

no. Because SAP preparses SDPs, so each and every SDP on the network  
would cause an Error box to pop up when you are listening to SDP.

> For the m= field i know nothing to sdp myself. but maybe the VLC
> implemetation don't relly on it, or just not co;plain when it's absent
> to support brocken annonces.

If there is no m= line then there is no single ES in the SDP. It's  
valid i guess, but shouldn't Crash VLC, nor would such a description  
be useful. However i doubt the SDP RFC excludes the possibility.  
(Mind you that RTSP RFC != SDP RFC in many ways).

DJ

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html