[vlc-devel] Re: [PATCH] http interface : fix the shuffle/loop/repeat buttons and highlights them when there are activated

[laurent Mutricy]

Sigmund Augdal Helberg wrote:
> On Wed, 2006-03-15 at 15:48 +0100, laurent Mutricy wrote:
> 
>>plain text document attachment (vlc_http_playlist_buttons.patch)
>>diff -Naur vlc-0.8.5-test1/share/http/js/functions.js vlc-0.8.5-test1-modif/share/http/js/functions.js
>>--- vlc-0.8.5-test1/share/http/js/functions.js	2006-03-15 15:39:16.000000000 +0100
>>+++ vlc-0.8.5-test1-modif/share/http/js/functions.js	2006-03-15 15:43:04.000000000 +0100
>>@@ -430,6 +430,19 @@
>>                 document.getElementById( 'btn_pause' ).setAttribute( 'title', 'Play' );
>>             }
>> 
>>+	    if( status.getElementsByTagName( 'random' )[0].firstChild.data == "1" )
>>+	    	document.getElementById( 'btn_shuffle').setAttribute( 'style', 'background: rgb( 170, 170, 170 );' );
>>+	    else
>>+	    	document.getElementById( 'btn_shuffle').setAttribute( 'style', '' );
>>+	    if( status.getElementsByTagName( 'loop' )[0].firstChild.data == "1" )
>>+	    	document.getElementById( 'btn_loop').setAttribute( 'style', 'background: rgb( 170, 170, 170 );' );
>>+	    else
>>+	    	document.getElementById( 'btn_loop').setAttribute( 'style', '' );
>>+	    if( status.getElementsByTagName( 'repeat' )[0].firstChild.data == "1" )
>>+	    	document.getElementById( 'btn_repeat').setAttribute( 'style', 'background: rgb( 170, 170, 170 );' );
> 
> Whouldn't it be better to use a css class for these?
Yes you are right it would be better
here is a new version

-- 
Mute
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vlc_http_playlist2.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20060315/66590208/attachment.ksh>