[vlc-devel] Re: vlc: svn commit r15655 (fkuehne)

[Felix Kühne]

On 2006-05-16 22:13:45 +0200 Clément Stenac <zorglub at diwi.org> wrote:

> I'm really a bit puzzled as to why you want to use interaction to get
> the name of the node.
> 
> Why not just ask the user with a simple box and create that node ?

Using the interaction-framework probably seems to be over the top for you, but due to OSX's / Cocoa's way of handling GUIs, creating that simple box is much more work than calling an interaction method.
As you know, that's a single-liner, while creating a box would either require me to copy the dialogue in the interaction-nib to another nib (plus around 6 bindings) or to write various lines to create the elements by hand.
So, using the interaction-framework in the OSX-GUI makes sense, since it reduces the binary's size (and my efforts ;) ), while there's no noticable draw back on the performance.


On 2006-05-16 21:46:19 +0200 Antoine Cellerier <dionoea at videolan.org> wrote:

> On Tue, May 16, 2006, Subversion daemon wrote:
>> * ask for the name of the new node through the interaction framework (node 
>> creation runs in a separate thread now to avoid interface blocking)
> 
> It might be a good idea to move all that to a core function (so that
> each interface doesn't have to re-implement the node creation thing with
> interaction)
I think that it is simpler and better in !Cocoa interfaces to use natives dialogues as Clément pointed out. The code duplication of the current implementation is neglectible in my opinion, so I wouldn't make a core-function out of this, also I wouldn't fight one, if you choose to create it.


Thanks you two for the feedback.

Best regards,
Felix

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html