[vlc-devel] Re: [PATCH] bugfix: mosaic-[hv]border reversed

[Christophe Mutricy]

On Tue, Oct 03, 06 at 22:40 +0200, Antoine Cellerier wrote:
> On Tue, Oct 03, 2006, Thomas Parmelan wrote:
> > I think I found 2 bugs related to mosaic-hborder and mosaic-vborder.
> > 1. The help says hborder means horizontal border and vborder means
> >    vertical border, whereas the code uses hborder as border height and
> >    vborder as border width!
> > 2. (minor) In a debug message of the MosaicCallback() function,
> >    p_sys->i_vborder is used instead of p_sys->i_hborder when parsing the
> >    mosaic-hborder option.
> > The attached patch (against trunk) fixes the code to match the help
> > text, but I can propose a patch the other way around if people think it
> > is better (but I would suggest renaming hborder to borderh and vborder
> > to borderw (NOT borderv) in this case!).
> 
> The borderh/borderw names seem better. Could you send a patch for those?

I also prefer this way as it doesn't break the compatibility with older
version.

Use add_deprecated()


-- 
Xtophe

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html