[vlc-devel] Re: [PATCH] Set TOS field - UDP streaming

[Anders Theodorsen]

> > If I do it IPv6 compatible by setting the TOS / Traffic field
> > respectively and also pass the parameter to the network core in a
> > better way is it possible to have it accepted?
>
> Most likely. We've had other people requesting this feature.

Sounds good. I'll try to write a better implementation of it.

>
> > How do you recommend I pass the parameter to the network core? As an
> > additional parameter in the function declaration?
>
> I'm not too fond of adding a new parameter because it will break both source
> and binary compatibility. Maybe adding an extra int net_SetDSCP( int fd, int
> dscp ); function would do. You can find the address family by calling
> getsockname on the file descriptor. I'm just not sure if it is still possible
> to set the DSCP after connect() as been called - should be ok for UDP, but
> might suck with TCP (and SCTP and DCCP, if we ever implement them).

My original implementation of this was to only do this on access
output->UDP. The DSCP value is also set in "Preferences" under "Stream
output->Access output->UDP". I think this makes sense, then it could
be implementeted in the other access-outputs if needed later. Or do
you think it should be a generic setting?

Cheers,
Anders

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html