[vlc-devel] Re: Yet another audioscrobbler patch

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Mon, 18 Sep 2006 08:29:53 +0200,
Clément Stenac <zorglub at diwi.org> a écrit :

> Hi,
> 
> This will crash at close if playlist is not running
> (p_playlist->p_input == NULL)

so, i'll check now.
> 
> Also, could you change things like 
> 
> intf_thread_t *p_intf 
> .
> .
> .
> p_intf = (intf_thread_t *) p_this;
> 
> to intf_thread_t *p_intf = (intf_thread_t *) p_this;

done
> 
> Thanks,
> Clément
> 

other changes:
don't keep track of p_input into p_sys, we'll find it at Close()
album tag is now optionnal (and don't segfault if it's not present)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFDrGwYWCeGMCv8Q8RAoj3AJ40R0/ecpgMTCZ0a86HbBN22AQ3oACggSQn
mv/a6kS//cAEuIUu/9qLIBs=
=w+Hg
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: application/octet-stream
Size: 6820 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20060918/9e59a537/attachment.obj>