[vlc-devel] Re: Find an error in vlm.c

[Jean-Paul Saman]

Jean-Baptiste KEMPF wrote:
> On Wed, Sep 27, 2006, ye zhang wrote :
> 
>>   in function  Manage( vlc_object_t* p_object ), near line 2471:
>>                   .......
>>                   else
>>                   {
>>                       if( vlm_MediaControl( vlm, p_media,
>>   p_instance->psz_name,
>>                                             "stop", 0 ) == VLC_SUCCESS )
>>   i--;
>>                   }
>>
>>   Is it should be 'j--' instead of  'i--';
>>   If use 'i--', 'i' will be little then -1 sometimes. Then the statement
>>    'vlm_media_t *p_media = vlm->media[i]; ' above will be wrong.

I doubt the solution as presented above is correct. Examining the code I 
wonder if it shouln't be p_media->i_instance-- iso j--;

Could you run a test with p_media->i_instance--; ?

> 
> 
> I think this post on the forum comes to the same conclusion, when i
> comes to -1; it segfaults.
> 
> http://forum.videolan.org/viewtopic.php?t=26642
> The line numbers have changed, be careful :D
> 
> 

Gtz,
Jean-Paul Saman.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html