[vlc-devel] Want to commit a fix for a Ticket #1162, but cant

[npl at chello.at]

I opened Ticket #1162 a few days ago, but I fixed it myself. Problem is that I cant edit Tickets and #videolan hasnt been helpful. Neither do I know in which format I should provide the patch.

The bug is in modules/demux/avi/libavi.c, starting with line 175:

if( p_chk->common.p_father->common.i_chunk_size > 0 &&
    ( stream_Tell( s ) >=
        (off_t)p_chk->common.p_father->common.i_chunk_pos +
        (off_t)__EVEN( p_chk->common.p_father->common.i_chunk_size ) ) )

change that to 

if( p_chk->common.p_father->common.i_chunk_size > 0 &&
    ( stream_Tell( s ) >
        (off_t)p_chk->common.p_father->common.i_chunk_pos + 
        (off_t)__EVEN( p_chk->common.p_father->common.i_chunk_size ) ) )

ie. the elements of a list werent enumerated till its end (stopped 8 bytes before). This obviously is a problem if the last chunk in a list is == 8 bytes (smallest possible vaild chunk). With the fix, we only stop if there is not enough room for another chunk.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html