[vlc-devel] Re: [PATCH] jack audio output

[Jon Griffiths]

Hmm,

The final patch I sent already had these two changes, plus a few
others that improve jack stability (such as always calling
jack_deactivate before jack_client_close) and speed (don't thrash the
cache in process()).

It looks like the wrong patch (or only part of the final one) was
applied. I'll do a full diff this evening and resend whats missing.

Cheers
Jon


--- Julien Plissonneau Duquène
<julien.plissonneau.duquene at savoirfairelinux.com> wrote:

> Hi,
> 
> When jack_client_new fails, the code currently in svn head will
> jump to
> error handling and will try to free p_sys->p_jack_ports, but the
> pointer
> is not intialized yet (crash). This is fixed by using calloc
> instead of
> malloc for p_sys.
> 
> It would be nice to have something to distinguish the client name
> in
> jack, as several VLC instances may be launched simultaneously. This
> is
> fixed below by adding the PID to the client name when registering
> with
> jack.
> 
> In the process renamed p_name to psz_name to follow code
> conventions.




__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html