[vlc-devel] [PATCH]Oversized subtitles

[Bernie Purcell]

I've just completed a patch for vout_subpictures.c that seems to fix the
problem reported by Hannes Domani with the rendering of subtitles in
resized video.
The problem is restricted to video modules that pass through native
resolutions to the the rendering and blending routine in
vout_subpictures; the x11 module is the only one I've found doing that
so far. Rather than simply patch it to correctly work out the scale in
these circumstances and blend to original video resolution I've taken
the approach that it would be nicer to have the text rendered at native
resolution - so this patch attempts to do that, producing much crisper
text now when x11 is chosen as output module, rather than eg. xvideo.
All of the changes necessary to implement this are in vout_subpictures,
which isn't code I normally mess with. I can't deny the possibility that
this code in particular might break anything else using subpictures, so
am posting this to the list to get some comments before committing. If I
don't hear anything bad I'll commit it late next week.
Anyone testing this patch should in particular try it with both x11 and
eg. xvideo selected as their output module, and should also toggle
between full-screen and normal mode a lot to see that everything works
as it should.
On a final note I don't seem to be able to get a runnable vlc from a
compilation of the current trunk, so I've produced this patch from a
slightly older revision with a couple of other files backported. I'm
hoping this won't have an impact, though.

Bitmap
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subs_fontsize.patch
Type: text/x-patch
Size: 16557 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070816/89ba42c0/attachment.bin>
-------------- next part --------------
_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel