[vlc-devel] [PATCH] QT playlist display bug

[Alexander Gall]

Can anybody please commit this fix or something equivalent?

I'm wondering why such an obvious bug isn't noticed by anyone.  It
appears that Qt doesn't check any assertions unless compiled in debug
mode (I find that really strange btw).  If they don't already do so,
it would be a really good idea if the VLC developers used a version of
Qt with debugging turned on to catch such inconsistencies.

-- 
Alex

On Tue, 17 Jul 2007 10:56:47 +0200, Alexander Gall <gall at switch.ch> said:

> vlc aborts with a QT assertion failure when clicking on any of the
> items in the top-level of the playlist (i.e. "Playlist", "SAP
> sessions", etc.)

> ASSERT: "last >= first" in file kernel/qabstractitemmodel.cpp, line 2071

> The attached patch aganinst a SVN snapshot from July 13 appears to fix
> this (in modules/gui/qt4).

> -- 
> Alex

> --- playlist_model.cpp.orig	2007-07-13 13:36:05.105694000 +0200
> +++ playlist_model.cpp	2007-07-17 10:45:14.309955000 +0200
> @@ -648,11 +648,13 @@
>      /* Clear the tree */
>      if( rootItem )
>      {
> +      if (rootItem->children.size()) {
>          beginRemoveRows( index( rootItem, 0 ), 0,
rootItem-> children.size() -1 );
>          qDeleteAll( rootItem->children );
rootItem-> children.clear();
>          endRemoveRows();
> +      }
>      }
>      if( p_root )
>      {

_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel