[vlc-devel] RTSP fallback to TCP broken

[Alexander Gall]

I noticed that fallback to TCP is not happening when no data is
received over UDP for a stream set up with RTSP.  I tracked this to
modules/demux/live555.cpp:RollOverTcp(), called from Demux()

    /* Reopen rtsp client */
    if( p_demux->s != NULL && ( i_return = Connect( p_demux ) ) != VLC_SUCCESS )
    {
        msg_Err( p_demux, "Failed to connect with rtsp://%s", p_sys->psz_path );
        goto error;
    }

It turned out that p_demux->s is NULL and the new RTSP session does
not get initiated.  The function actually returns success to Demux()
in this case, which happily continues to wait for data, which never
arrives.

I simply removed the check p_demux-> s != NULL to see what happens and
everything appeared to work fine.  I leave it to you guys to find a
proper fix :-)

-- 
Alex

_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel