[vlc-devel] [PATCH] oversized subtitles

Hannes Domani ssbssa at yahoo.de
Mon Aug 6 12:50:57 CEST 2007


Hello

I can send you a sample-ssa tomorrow if you want.
As far as i remember the relative size was irrelevant
(or anything else).

PS: i'm absolutely sure that the old line was WRONG, i
knew this the moment i read it.

regards
Domani Johannes


--- Bernie Purcell <b.purcell at adbglobal.com> schrieb:

> Hi Hannes,
> 
> Do you by any chance have a sample file that
> exhibits the problem you 
> mention? Are there any other relevant factors, like
> the size of the 
> playback window relative to the source size of the
> video?
> I'm happy to commit the patch but I'm a little
> concerned that it is making 
> a patch against all subpicture planes, not just
> those that subtitles might 
> be being rendered on, and that means a fair bit of
> regression testing to 
> make sure it doesn't break anything else. It would
> help to get a better 
> idea of what is causing the problem.
> 
> Bitmap
> 
> 
> 
> 
> Hannes Domani <ssbssa at yahoo.de> 
> Sent by: vlc-devel-bounces at videolan.org
> 02/08/2007 08:13 PM
> Please respond to
> Mailing list for VLC media player developers
> <vlc-devel at videolan.org>
> 
> 
> To
> vlc-devel <vlc-devel at videolan.org>
> cc
> 
> Subject
> [vlc-devel] [PATCH] oversized subtitles
> 
> 
> 
> 
> 
> 
> hello
> 
> this solves the problem mentioned in
> http://forum.videolan.org/viewtopic.php?f=14&t=39357
> 
> regads
> Domani Johannes
> 
> 
>       __________________________________
> Wissenswertes zum Thema PC, 
> Zubehör oder Programme. BE A BETTER INTERNET-GURU! 
> www.yahoo.de/clever--- 
> src/video_output/vout_subpictures.c             
> 2007-08-02 
> 08:21:02.265625000 +0200
> +++ src/video_output/vout_subpictures.c         
> 2007-08-02 
> 08:22:59.312500000 +0200
> @@ -603,7 +603,8 @@
>          {
>              i_scale_height = i_scale_height *
> p_fmt->i_height /
>                              
> p_subpic->i_original_picture_height;
> -            i_scale_width = i_scale_height *
> i_scale_height / 
> p_fmt->i_height;
> +            i_scale_width = i_scale_width *
> p_fmt->i_height /
> +                            
> p_subpic->i_original_picture_height;
>          }
>  
>          /* Set default subpicture aspect ratio */
> _______________________________________________
> vlc-devel mailing list
> vlc-devel at videolan.org
> http://mailman.videolan.org/listinfo/vlc-devel
> 
> 



      Machen Sie Yahoo! zu Ihrer Startseite. Los geht's: 
http://de.yahoo.com/set
_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list