[vlc-devel] vlc: svn commit r21610 (funman)

[Rémi Denis-Courmont]

Le vendredi 31 août 2007, Subversion daemon a écrit :
> r21610 | funman | 2007-08-31 12:44:43 +0200 (Fri, 31 Aug 2007) | 1
> line Changed paths:
>    M /trunk/modules/gui/qt4/menus.cpp
>    M /trunk/modules/gui/qt4/qt4.cpp
>
> Unblocks SIGCHLD in qt4 thread

For yet another time: This is *totally* flawed.

You ***CANNOT*** know which thread will receive the SIGCHLD signal. It 
could be the sigwait thread, it *might* by chance be the Qt4 thread, or 
it could be any other thread that would not block SIGCHLD.

As such if your code need to receive a signal, it is simply PLAIN 
BROKEN. There are only two exceptions:
1/ if the signal is emitted with pthread_kill() - not applicable here.
2/ single thread per process - if your library needs this, then you 
cannot use it in VLC at all.

Please revert.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070831/f3672d5c/attachment.sig>