[vlc-devel] [PATCH] Jack input UI and bugfixes + Vorbis 8 channels

[Pierre-Luc Beaudoin]

Hi,

For the first comment, please read my other email regarding
jack-fixes.patch.

Here is a new version of the vorbis only patch.  I removed all my
debuging stuff.  There was a return which should not have been commented
-- solved.  As for the "aout_DateSet( &p_sys->end_date, 0 );" I deleted,
it was a duplication, aout_DateInit already do this.


Le vendredi 31 août 2007 à 10:26 +0300, Rémi Denis-Courmont a écrit :

> Le lundi 27 août 2007, Pierre-Luc Beaudoin a écrit :
> > Here is my patch introducing :
> > - a Jack input UI (qt4 only) under Capture Device tab
> > - corrections to bugs in sound quality with Jack as an Input
> > - allow to stream up to 8 channels of sound through Vorbis.
> 
> If I understand correctly, you are adding a dependency on libm and float 
> point numbers just for the sake of rounding a value to a power of 2. I 
> doubt that is really wise.
> 
> Also, some of the commenting out in the ogg patch seems bogus.
> 
> 
> Regards,
> 

--
Pierre-Luc Beaudoin
Savoir-faire Linux


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070831/7fc8955e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-9chans.patch
Type: text/x-patch
Size: 2635 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070831/7fc8955e/attachment.bin>