[vlc-devel] vlc: svn commit r23448 (funman)

[Jean-Paul Saman]

Subversion daemon wrote:
> r23448 | funman | 2007-12-04 16:49:28 +0100 (Tue, 04 Dec 2007) | 3 lines
> Changed paths:
>    M /trunk/src/video_output/vout_intf.c
> 
> vout_Snapshot(): hability to specify width & height when the snapshot isn't taken by an object.
> Value of 0 for width OR height means that we want to keep the original aspect ratio.
> 
>  > http://trac.videolan.org/vlc/changeset/23448
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
> 

line 532 (src/video_output/vout_intf.c already specifies what you wanted 
to do, which is even in the same function as the below snippit.

/* FIXME: should not be hardcoded. We should be able to
         specify the snapshot size (snapshot-width and snapshot-height). */
         fmt_out.i_width = var_GetInteger( p_vout, "snapshot-width" );
         fmt_out.i_height = var_GetInteger( p_vout, "snapshot-height" );
         fmt_out.i_chroma = VLC_FOURCC( 'p','n','g',' ' );

You are querying "snapshot-width" and "snapshot-height" twice in the 
same function, which is a bit overkill. Line 708 and 709 can be deleted 
if you ask me.

Gtz,
Jean-Paul Saman.