[vlc-devel] vlc: svn commit r23535 (ivoire)

[Rafaël Carré]

2007/12/11, Subversion daemon <svn at videolan.org>:
> r23535 | ivoire | 2007-12-11 00:12:45 +0100 (Tue, 11 Dec 2007) | 1 line
> Changed paths:
>    M /trunk/include/vlc_update.h
>    M /trunk/modules/control/rc.c
>    M /trunk/modules/gui/qt4/dialogs/help.cpp
>    M /trunk/modules/gui/qt4/dialogs/help.hpp
>    M /trunk/src/misc/update.c
>
> Modify the update system : I will add more functionnality but this is the beginning
>  > http://trac.videolan.org/vlc/changeset/23535

It looks good.

A few points:

* http://zen.via.ecp.fr/~ivoire/videolan/update is not accessible, it
would have be useful for testing purposes.
Anyway, I'll use one of the others UPDATE_VLC_STATUS_URL , but if you
don't use this url anymore, you can remove it from the code

* We don't provide 0.8.6d binaries for BeOS, afaik only MYOB can do
builds, so do we provide "official" support for this arch, including
updates ?
I'm not sure but it seems that trunk doesn't compile on BeOS, so
please, BeOS people, enlight us ^^

* Instead of this:
if( p_update->release.psz_svnrev )
{
free( p_update->release.psz_svnrev );
p_update->release.psz_svnrev = NULL;
}

You can use FREENULL( p_update->release.psz_svnrev );

The FREENULL macro is defined in vlc_common.h , and there is no need
to check for a pointer being != NULL before free()ing it.

*
if( psz_svnrev )
p_update->release.psz_svnrev = psz_svnrev;
else
p_update->release.psz_svnrev = STRDUP( "" );

can be:

p_update->release.psz_svnrev = psz_svnrev ? psz_svnrev : STRDUP( "" );

it's much shorter :)

* static int cmp( int i1, i2 )
you can use (i1 - i2) instead

The whole CompareReleases() seems strange to me you could use:
if ( p1->major <= p2->major || p1->minor <= p2->minor ...... ||
p1->last < p2->last )

Thanks.

I'll merge my work in the following days, but no short promise since
i'm running in some real life troubles...

Please admins, can you sign the different status files:
gpg --sign --armor --detach status-XXX

An invalid signature would be welcomed too :)

-- 
Rafaël Carré