[vlc-devel] vlc: svn commit r23710 (ivoire)

[Rafaël Carré]

Le Tue, 18 Dec 2007 16:51:29 +0100 (CET),
Subversion daemon <svn at videolan.org> a écrit :

> r23710 | ivoire | 2007-12-18 16:51:29 +0100 (Tue, 18 Dec 2007) | 1
> line Changed paths:
>    M /trunk/include/vlc_update.h
>    M /trunk/modules/control/rc.c
>    M /trunk/modules/gui/qt4/dialogs/help.cpp
>    M /trunk/modules/gui/qt4/dialogs/help.hpp
>    M /trunk/src/misc/update.c
> 
> Add fonctions to the update system : all is in a thread now. The rc
> interface doesn't use the update system for the moment and there
> isn't any encryption for the moment ...
>  > http://trac.videolan.org/vlc/changeset/23710

Cool, we are getting closer :)

I have a few remarks:

rc code should be disabled if it is broken/memleaking (use #if 0)

You don't need to create a custom vlc_object_t (update_check_thread_t)
to launch a thread.

In this code:
if( !p1->psz_extra || !p2->psz_extra || !p1->psz_svnrev
|| !p2->psz_svnrev )
You don't check the case where p1->psz_extra isn't empty for example.

You must check asprintf() return value, since memory isn't infinite (I
would like ....)

Also you forget to check strrchr() return value.

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071218/fa8f572e/attachment.sig>