[vlc-devel] vlc: svn commit r23803 (courmisch)

Rémi Denis-Courmont rdenis at simphalempin.com
Sat Dec 22 15:28:03 CET 2007

Le Saturday 22 December 2007 16:11:44 Subversion daemon, vous avez écrit :
> r23803 | courmisch | 2007-12-22 15:11:42 +0100 (Sat, 22 Dec 2007) | 4 lines
> Changed paths:
>    M /trunk/modules/access/file.c
>  - Parse seek offsets as unsigned (why they were signed in the first
> place??)

For some reason the ASF demux tries to seek to negative offsets. This seems to 
be an integer overflow. At least, as far as I understand, the three different 
places whereby it invokes stream_Seek() are not supposed to yield negative 
offsets. Besides, negative offsets make absolutely no sense anyway.

I will not completely rule out that #1404 would actually be a bug in the 
access_file mmap code, but it *very* much seems like an ASF bug revealed by 
mmap. Needless to say, I have no idea how to fix this. As such, I have no 
intention to dedicate any more of my time to this, pending further relevant 
informations from someone else.

Rémi Denis-Courmont
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20071222/be74f024/attachment.sig>

More information about the vlc-devel mailing list