[vlc-devel] [PATCH] allow syslogging in trunk

[Pavlov Konstantin]

Hello.

Playing with trunk for some time got a nasty crash with :
./vlc -vvv -I telnet --syslog /var/ftp/video/some.movie.doesnt.matter.avi

bt:
#0  libvlc_InternalAddIntf (p_libvlc=0x0, psz_module=0xb7fc6e88 "logger,none", 
b_block=0, b_play=0,  i_options=1, ppsz_options=0xbf871424) at 
libvlc-common.c:1065
#1  0xb7f245c1 in libvlc_InternalInit (p_libvlc=0x804a810, i_argc=6, 
ppsz_argv=0xbf871604)
    at libvlc-common.c:880
#2  0xb7f21b16 in VLC_Init (i_object=0, i_argc=6, ppsz_argv=0xbf871604) at 
libvlc.c:123
#3  0x08048863 in main (i_argc=6, ppsz_argv=0xbf871604) at src/vlc.c:102

looks like libvlc_InternalAddIntf is called with p_libvlc == 0, so i "fixed" 
it with attached patch.

Ok, now we have syslogging going fine, but when closing vlc i have a segfault 
too. One of the latest messages in syslog is:
Feb  6 03:33:05 snowflake VLC: message: message queue overflowed

bt:

#0  0xb7dca343 in vfprintf () from /lib/libc.so.6
#1  0xb7deb8d2 in vasprintf () from /lib/libc.so.6
#2  0xb7f6e7ee in QueueMsg (p_this=0x804a810, i_queue=0, i_type=1, 
psz_module=0xb7f88b68 "main",
    psz_format=0xb7f891bc "thread %li: mutex_lock failed at %s:%d (%d:%s)",
    _args=0xbf68d714 "ю\026ж╥<\200Ы╥l\001") at misc/messages.c:312
#3  0xb7f6fa7b in __msg_Generic (p_this=0x804a810, i_queue=0, i_type=1, 
psz_module=0xb7f88b68 "main",
    psz_format=0xb7f891bc "thread %li: mutex_lock failed at %s:%d (%d:%s)") at 
misc/messages.c:237
etcetcetc..

It looks like logger thread cant flush everything too fast.

any suggestions on what could be done ?

-- 
Pavlov Konstantin,
ALT Linux Team,
jid: thresh at altlinux.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-trunk-syslog-enable.patch
Type: text/x-diff
Size: 527 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070206/e34876ce/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070206/e34876ce/attachment.sig>