[vlc-devel] Re: Patch to add multi-pass encoding support for H.264

[Sašo Kiselkov]

Rémi Denis-Courmont wrote:
> Le jeudi 8 février 2007 23:24, Sašo Kiselkov a écrit :
>> I'm submitting a patch which adds multi-pass encoding to VLC's H.264
>> codec module. I'm not sure about the memory management in it, so it
>> might need some revision. I've been seriously missing multi-pass
>> encoding in VLC, as it dramatically improves quality and lowers
>> bitrate consumption.
>>
>> Anybody interrested in including it in the mainline VLC distribution?
> 
> I think you have to free(val.psz_string); for each var_Get(). You could 
> also use strdup() instead of malloc()+strcpy(), and in either case you 
> probably need to free() the parameters string from the Close() 
> function.
> 

I've adjusted the patch to just assign the value from var.psz_string and
free() the value in Close(). Anybody interrested in testing it?

--
Saso
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264-multipass.patch
Type: text/x-patch
Size: 3063 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070209/c6b529a6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070209/c6b529a6/attachment.sig>