[vlc-devel] Re: modules/codec/ffmpeg/mux.c oddness
Remi Denis-Courmont
rem at videolan.org
Thu Feb 15 15:31:50 CET 2007
On Wed, 14 Feb 2007 17:34:32 +0100, Olivier Houchard <cognet at ci0.org> wrote:
> In modules/codec/ffmpeg/mux.c, IOWrite(), the callback used by ffmpeg to
> write
> into the buffer, wrongly assumes sout_AccessWrite() returns the number of
> bytes
> written. It is true for the "file" access_out, however it is wrong for
> others,
> such as http, which just returns 0 on success. I applied the attached
> patch,
> which just returns the value returned by sout_AccessWrite() to ffmpeg.
> That
> should work, as ffmpeg assumes any negative value to be an error, and just
> discards any >= 0 value.
> Most other muxers just ignore the return value of sout_AccessWrite().
Still, this looks very much like a bug in the http access output rather
than ffmpeg muxer.
--
Rémi Denis-Courmont
http://www.remlab.net/
--
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
More information about the vlc-devel
mailing list