[vlc-devel] Re: vlc: svn commit r18837 (courmisch)

[Pierre d'Herbemont]

On 14 févr. 07, at 19:43, Subversion daemon wrote:

> r18837 | courmisch | 2007-02-14 19:43:27 +0100 (Wed, 14 Feb 2007) |  
> 2 lines
> Changed paths:
>    M /trunk/include/vlc_network.h
>    M /trunk/src/network/tcp.c
>
> Inline net_ListenTCP
>
>> http://trac.videolan.org/vlc/changeset/18837

This one breaks Mac OS X target where HAVE_SHARED_LIBVLC is not defined:

first it warns us:
../../include/vlc_network.h: In function '__net_ListenTCP':
../../include/vlc_network.h:85: warning: implicit declaration of  
function 'net_Listen'
../../include/vlc_network.h:85: warning: return makes pointer from  
integer without a cast

then, it failed with an undefined symbol net_Listen when building  
telnet.c.

Here is an easy fix for it... But the vlc-api.pl needs probably some  
rework to handle this case.

BTW, why don't we make use of the -undefined symbol_lookup on Mac OS  
X >= 10.4?

Pierre.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_api_declaration.diff.txt
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070215/a085dd4d/attachment.txt>
-------------- next part --------------