[vlc-devel] Re: vlc: svn commit r18887 (damienf)

[Damien Fouilleul]

Christophe Mutricy wrote:
> On Mon, Feb 19, 07 at 20:00 +0100, Subversion daemon wrote:
>   
>> r18887 | damienf | 2007-02-19 20:00:27 +0100 (Mon, 19 Feb 2007) | 2 lines
>> Changed paths:
>>    M /trunk/extras/contrib/src/Patches/dvdnav.patch
>>     
> [...]
>   
>> - contribs: misc fixes for cygwin mostly
>>     
>
> This breaks win32 build on linux ( at least altair and my laptop),
> indeed I can't find a library with gettimeofday in mingw32 nor on MSDN.
>
> Actually i had to implement it in libvlc recently has it was needed
> for some sap rework.
>
> So is it defined in cygwin? where? if yes we should use a cleverer #if. 
>
>   
it's not cygwin specific, latest mingw has a version of gettimeofday() 
and dvdnav is forcing it's own version for win32, which is causing a 
compile problem.
I guess the proper fix would be to amend dvdnav configure.ac to check 
for gettimeofday() and use #ifndef HAVE_GETTIMEOFDAY instead of #if 0

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html