[vlc-devel] Re: vlc: svn commit r18958 (fenrir)

[Derk-Jan Hartman]

On 22-feb-2007, at 21:43, Subversion daemon wrote:
> r18958 | fenrir | 2007-02-22 21:43:28 +0100 (Thu, 22 Feb 2007) | 11  
> lines
> Changed paths:
>    M /trunk/src/video_output/vout_subpictures.c
>
> Fixed subtitle/osd memory leaks (subpicture_region_t->psz_text was  
> not freed).
>
>  I think we have a potential bug with the way subpicture_region_t- 
> >p_style
> is used.
>  Decoders allocate p_style memory in their context, so we don't  
> free it in
> spu_DestroyRegion. As vout object can live longer than decoder, I  
> think
> p_style might be used after the decoder has destroyed it.
>
>  Can someone, who has worked on osd/spu internal, comment ?
>
>
>> http://trac.videolan.org/vlc/changeset/18958

I think you might be right. I hadn't thought about this. It's  
implemented like this to prevent having to allocate it on every  
region, and duplicated this data for each and every region. (because  
often it stays unchanged). Does anyone have an idea to improve this?

DJ

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html