[vlc-devel] Re: [Patches] for vlc-0.9.0-svn

[xxcv]

Jean-Paul Saman wrote:
>>
>>  /***************************************************************************** 
>>
>>   * The vcddev structure
>>   
>> *****************************************************************************/ 
>>
>> +#ifdef WIN32
>> +typedef WINAPI DWORD (*GETASPI32SUPPORTINFO)(VOID);
>> +typedef WINAPI DWORD (*SENDASPI32COMMAND)(LPVOID);
>> +#endif
>> +
>>
>> --- modules/access/vcd/cdrom.c~    2006-11-23 15:03:42.000000000 +1100
>> +++ modules/access/vcd/cdrom.c    2006-11-23 15:03:49.000000000 +1100
>> @@ -1151,8 +1151,8 @@
>>      else
>>      {
>>          HMODULE hASPI = NULL;
>> -        long (*lpGetSupport)( void ) = NULL;
>> -        long (*lpSendCommand)( void* ) = NULL;
>> +        GETASPI32SUPPORTINFO lpGetSupport = NULL;
>> +        SENDASPI32COMMAND lpSendCommand = NULL;
>>          DWORD dwSupportInfo;
>>          int i, j, i_hostadapters;
>>          char c_drive = psz_dev[0];
>> @@ -1160,9 +1160,9 @@
>>          hASPI = LoadLibrary( "wnaspi32.dll" );
>>          if( hASPI != NULL )
>>          {
>> -            (FARPROC) lpGetSupport = GetProcAddress( hASPI,
>> +            lpGetSupport = (GETASPI32SUPPORTINFO) GetProcAddress( 
>> hASPI,
>>                                                       
>> "GetASPI32SupportInfo" );
>> -            (FARPROC) lpSendCommand = GetProcAddress( hASPI,
>> +            lpSendCommand = (SENDASPI32COMMAND) GetProcAddress( hASPI,
>>                                                        
>> "SendASPI32Command" );
>>
Access vcd module does not compile under mingw32 gcc4 thats why the 
patch is like this.
>> --- modules/codec/dmo/dmo.h~    2006-10-06 02:56:09.000000000 +1000
>> +++ modules/codec/dmo/dmo.h    2006-10-06 03:20:42.000000000 +1000
> Why remove static and GUID here?
> Why move them down from their original declaration? Why is the static 
> removed?
>
Because dmo.h is too weird and mingw32 gcc4 do not understand them, if 
static is there mingw32 gcc4 refuse to compile.
>>
>> -    p_playlist_dialog->AddPendingEvent( event );
>> +    p_playlist_dialog->ProcessEvent( event );
>>  
This important fix is for wx playlist interface to avoid crashing, when 
playlist item jumps to next, it needs immediate attention before the 
file starts playing and then the Pending event got lost leading to crash.

Anyways gcc4 isn't officially properly supported by mingw.org I think 
that's why they never released a gcc4 compiler for mingw32.

As for the AAC SBR transcode patch I have updated it, just let me know 
if you want it.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html