[vlc-devel] Re: [0.8.6-bugfix] AAC SBR transcode fix

[xxcv]

Decoders, is it refer to all audio decoders ?
fmt_last.audio.i_rate = the last (currently) decoded audio block 
sampling rate
fmt_in.audio.i_rate = the first decoded audio block sampling rate

I don't know if sampling rate will change for any other audio codecs 
except AAC SBR
For example does WAVE change sampling rate ? or mp3 or vorbis or Audio 
Tapes or CD or mp2a or mpga ?
I don't know who puts this line there, "fmt_last.audio.i_rate = 
id->p_decoder->fmt_in.audio.i_rate;" ,
and for what reason it is there, should we ask him why ? This is like 
telling the decoder saying
current audio block been decoded to wrong sampling rate, and, overriding 
current value with old value.
So is it wrong to comment this line out ?

Christophe Mutricy wrote:
>> --- modules/stream_out/transcode.c~	2006-09-22 05:29:10.000000000 +1000
>> +++ modules/stream_out/transcode.c	2007-01-15 14:04:33.000000000 +1100
>> @@ -1255,7 +1255,7 @@
>>          audio_BitsPerSample( id->p_decoder->fmt_out.i_codec );
>>      fmt_last = id->p_decoder->fmt_out;
>>      /* FIX decoders so we don't have to do this */
>> -    fmt_last.audio.i_rate = id->p_decoder->fmt_in.audio.i_rate;
>> +//    fmt_last.audio.i_rate = id->p_decoder->fmt_in.audio.i_rate;
>>     
> Are all the decoders fixed ? have you tested with other input codec ?
>
>   

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html