[vlc-devel] Re: [PATCH] modules/codec/spudec/parse.c

[Hytham Alihassan]

In the following if
statement, a check is being performed to confirm the validity of
p_spu->i_start.  If the pointer proves to be undefined, not only
should the code report an error, but it should also return so that a
null pointer does not get referenced.

This issue has caused me problems in the past, and since I was able to
compile VLC on my system and make this modification, I no longer had an
unstable VLC when trying to view subtitles on a particular mp4 file (see
https://www.videolan.org/viewtopic.php?t=28641&view=previous&sid=3874fe79507030e9c004faedaf33f51ffor
more information).

Thanks,
Hytham (iChief)

On 1/21/07, Antoine Cellerier <dionoea at videolan.org> wrote:
>
> Please provide comments when submitting patches.
>
> On Sun, Jan 21, 2007, Hytham Alihassan wrote:
> >    Index: parse.c
> >    ===================================================================
> >    --- parse.c (revision 18621)
> >    +++ parse.c (working copy)
> >    @@ -350,6 +350,7 @@
> >    if( !p_spu->i_start )
> >    {
> >    msg_Err( p_dec, "no `start display' command" );
> >    + return VLC_EGENERIC;
> >    }
> >    if( p_spu->i_stop <= p_spu->i_start && !p_spu->b_ephemer )
> --
> Antoine Cellerier
> dionoea
>
> --
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070121/8b188746/attachment.html>