[vlc-devel] [PATCH] Make USF subtitles conform better to spec

[Bernie Purcell]

Hi Fenrir,

The whitespace removal code does have similar code in freetype.c. It has 
been submitted as part of a much larger set of corrections that need to be 
made to the freetype module, and just hasn't been included here.
I'll work on changing the memcpy to memmove and strlcpy instead of strncpy 
but won't have a chance till tomorrow.

Bernie




Laurent Aimar <fenrir at via.ecp.fr> 
Sent by: vlc-devel-bounces at videolan.org
30/06/2007 09:49 AM
Please respond to
VLC media player developers <vlc-devel at videolan.org>


To
vlc-devel at videolan.org
cc

Subject
Re: [vlc-devel] [PATCH] Make USF subtitles conform better to spec






On Fri, Jun 22, 2007, Bernie Purcell wrote:
> This patch is a tidied up version of code that was originally submitted
> in a much larger patch. It is still a large patch, but now, at least,
> most of the work centres solely on the subsdec.c module.
> [....]
 Is there any comment about this patch ?
 If no I will commit it in a few days (3-4, with remarks below fixed).

A few remarks:

 - The code that removes multiple-spaces exists in quartztext and subsdec.
  Is that wanted ? And if so why it is not also in freetype renderer ?

 - memcpy( &ptr[x], &ptr[y], size ) is wrong.
  You have to use memmove when source and destination overlaps. It is used 
in
  quartztext and subsdec when removing multiple-spaces

 - You can use strlcpy(p,s,l) instead of strncpy( p, s, l); p[l] = 0;

-- 
fenrir

_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070701/21d38dad/attachment.html>
-------------- next part --------------
_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel