[vlc-devel] Memory corruption in playlist handling

Pierre d'Herbemont pdherbemont at free.fr
Mon Jul 9 13:57:29 CEST 2007


And it seems to come from the fact that p_instance->p_callback_list isn't
initialized to NULL. I'll post a fix tonight, though if someone want to test
out, the initialization could be added in
src/control/event.c:libvlc_event_init().

Pierre.

Selon Pierre d'Herbemont <pdherbemont at free.fr>:

> Hello Olivier,
>
> The media_* is not really over, but, weirdly enough, it shouldn't be directly
> responsible for this, as these function doesn't use media_instance nor
> media_descriptor. I really tend to think that the guilty code is in the input
> event code, which was newly added by me. (It listens to new input event, thus
> everything could goes wrong from here).
>
> I'll have a look tonight.
>
> Thanks for pointing this out,
>
> Pierre.
>
> Selon Olivier Aubert <olivier.aubert at liris.cnrs.fr>:
>
> > Hello
> >
> > I do not know if the transition to mediainstance* objects is over by
> > now, but it seems to have triggered a memory corruption somewhere, which
> > can be triggered notably through the mediacontrol API:
> >
> > > import vlc
> >
> > > mc=vlc.MediaControl('--plugin-path /home/oaubert/src/vlc-test'.split() )
> > # Harmless warning:
> > [00000297] main playlist error: Reloading playlist not implemented.
> >
> > > mc.playlist_add_item('/tmp/k.mpg')
> >
> > > mc.playlist_get_list()
> > ['/tmp/k.mpg']
> >
> > > mc.start(0)
> > [00000304] access_directory access error: : No such file or directory
> > [00000304] access_file access error: cannot open file  (No such file or
> > directory)
> > [00000302] main input error: open of `PüPüpg' failed: could not create
> > access: no suitable access2 module
> >                                      ^^^^^^^^
> >
> > > mc.playlist_get_list()
> > ['dead input']
> >
> > # And another try to start the movie definitely corrupts memory:
> > > mc.start(0)
> > [00000297] main playlist error: thread -1210119984: mutex_lock failed at
> > ../../vlc-trunk/src/input/item.c:101 (22:Invalid argument)
> > [00000297] main playlist error: thread -1210119984: mutex_unlock failed at
> > ../../vlc-trunk/src/input/item.c:104 (22:Invalid argument)
> >
> > AFAIK, the python bindings or mediacontrol is not in cause here, since
> > the playlist content is correct and the start method merely calls
> > playlist_Play.
> >
> > Is anyone investigating this ?
> >
> > Olivier
> >
> > _______________________________________________
> > vlc-devel mailing list
> > vlc-devel at videolan.org
> > http://mailman.videolan.org/listinfo/vlc-devel
> >
>
>
> _______________________________________________
> vlc-devel mailing list
> vlc-devel at videolan.org
> http://mailman.videolan.org/listinfo/vlc-devel
>


_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list