[vlc-devel] [PATCH] free fmt.out.p_extra in codec/*

Ilkka Ollakka ilkka.ollakka+vlc at oamk.fi
Fri Jul 6 12:44:36 CEST 2007

On pe  6. heinäkuuta 2007 12:33:40, Laurent Aimar wrote:
> Hi,
> On Fri, Jul 06, 2007, Ilkka Ollakka wrote:
> > Included patch that adds free fmt.out.p_extra in codec Close if there's
> > malloc for that somewhere. Seems that that was only checked in
> > transcode_video_new in modules/stream_out/transcode.c and not at all
> > anywhere else (not in transcode_video_close).
>  Cleaning up fmt_in/out is not needed at all as src/input/decoder.c already
> do it (beside thoses values might still be in use in src/input...)
>  Cleaning up p_context in ffmpeg is not needed too because avcodec 
> free it (avcodec might still uses them until context is closed)
>  Did you see a memleak using valgrind ?

Didn't test those with valgrind, just didn't found where they were

Ilkka Ollakka
We are confronted with insurmountable opportunities.
		-- Walt Kelly, "Pogo"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070706/7b2b6898/attachment.sig>
-------------- next part --------------
vlc-devel mailing list
vlc-devel at videolan.org

More information about the vlc-devel mailing list