[vlc-devel] vlc: svn commit r20729 (jb)

Ilkka Ollakka ilkka.ollakka+vlc at oamk.fi
Thu Jul 19 15:24:31 CEST 2007


Seems that there's small problem with this patch, in line 2138 there's
check ( k == (uint32_t)i_len ) || ( ( k > 0 ) ..
so if both i_len and k are 0 that's true, but next line there
ft_style_t p_style = pp_char_styles[ k - 1 ]; and that can be tricky if
k and i_len are both 0.

I tested and just add that k > 0 test also for that k == i_len test
fixed crash that I had in there. (subtitles embedded inside mp4-files
crashed in first draw)

Ilkka Ollakka
Good day for a change of scene.  Repaper the bedroom wall.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070719/90ce4c24/attachment.sig>
-------------- next part --------------
vlc-devel mailing list
vlc-devel at videolan.org

More information about the vlc-devel mailing list