[vlc-devel] vlc: svn commit r20729 (jb)

[Bernie Purcell]

Hi Ilkka,

I was responsible for the original patch JB submitted, so it's my fault, 
sorry. Looking at the code, I think a more effective fix is to not enter 
the ProcessNodes() function at all if i_len is 0 because we're just 
wasting our time. I'm curious as to what subtitles produced the effect of 
getting a 0 length through though - something I've overlooked somewhere. 
I've made a change to skip the ProcessNodes() function on 0-length input 
in revision 20839 - if you could confirm it has fixed your problem, or 
provide me with subtitle details to reproduce it, I'd appreciate it.

Thanks

Bitmap



Ilkka Ollakka <ilkka.ollakka+vlc at oamk.fi> 
Sent by: vlc-devel-bounces at videolan.org
19/07/2007 11:24 PM
Please respond to
VLC media player developers <vlc-devel at videolan.org>


To
VLC media player developers <vlc-devel at videolan.org>
cc

Subject
Re: [vlc-devel] vlc: svn commit r20729 (jb)







Hi,

Seems that there's small problem with this patch, in line 2138 there's
check ( k == (uint32_t)i_len ) || ( ( k > 0 ) ..
so if both i_len and k are 0 that's true, but next line there
ft_style_t p_style = pp_char_styles[ k - 1 ]; and that can be tricky if
k and i_len are both 0.

I tested and just add that k > 0 test also for that k == i_len test
fixed crash that I had in there. (subtitles embedded inside mp4-files
crashed in first draw)


-- 
Ilkka Ollakka
Good day for a change of scene.  Repaper the bedroom wall.
[attachment "attzp8dr.dat" deleted by Bernie Purcell/ADB] 
_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070720/deddf1d9/attachment.html>
-------------- next part --------------
_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel